Completeness testing #6773
Merged
Completeness testing #6773
+2,749
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code snippets from snippet-generate action
Member
|
Works for me. Note, there is so much here that I didn't scrutinize the code. |
Contributor
|
I checked higher genus and groups carefully, and also spot checked a few other sections. This looks good to me. Is this about ready to merge? |
Member
|
This looks great! I haven't checked everything one could check but was happy with what I checked. I'll note that there are many cases where we have complete data but this is not noted (e.g. we have every elliptic curve over Q with good reduction away from 2). We might want to think about ways to easily add additional completeness criteria for special cases of interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds messages when search results are complete.
See this search on blue.lmfdb.xyz for example. There are a bunch of tests of the new functionality in the
test_utils.pyfile.Most of the completeness criteria were drawn from completeness knowls, but some were adapted from code that used to run on @jwj61's hobbes server with a similar goal, which he kindly provided.