Skip to content

Run without terminal for non-debug Windows builds #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhysSong merged 7 commits into from
Jan 8, 2024
Merged

Run without terminal for non-debug Windows builds #7022

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7e867b
set win32 flag
Rossmaxx Dec 16, 2023
64f33f8
added mingw too to win32 flag + dom's suggestions
Rossmaxx Dec 23, 2023
7ef6e5f
revert unnecessary changes i made.
Rossmaxx Dec 24, 2023
681e938
simplify msys linker flag condition
Rossmaxx Dec 24, 2023
a939c2f
removed extra whitespace
Rossmaxx Dec 24, 2023
dce6ec0
whitespace change 2
Rossmaxx Dec 24, 2023
5d23e6e
Merge branch 'LMMS:master' into win32-flag-cmake
Rossmaxx Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,22 +210,16 @@ ENDFOREACH()

set_target_properties(lmms PROPERTIES
ENABLE_EXPORTS ON
WIN32_EXECUTABLE $<NOT:$<CONFIG:DEBUG>>
)

IF(LMMS_BUILD_WIN32)
IF(NOT MSVC)
SET_PROPERTY(TARGET lmms
APPEND_STRING PROPERTY LINK_FLAGS " -mwindows"
)
ENDIF()
IF(LMMS_BUILD_MSYS)
# ENABLE_EXPORTS property has no effect in some MSYS2 configurations.
# Add the linker flag manually to create liblmms.dll.a import library
SET_PROPERTY(TARGET lmms
APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--out-implib,liblmms.dll.a"
)
ENDIF()
ELSE()
IF(LMMS_BUILD_MSYS)
# ENABLE_EXPORTS property has no effect in some MSYS2 configurations.
# Add the linker flag manually to create liblmms.dll.a import library
SET_PROPERTY(TARGET lmms
APPEND_STRING PROPERTY LINK_FLAGS " -Wl,--out-implib,liblmms.dll.a"
)
ELSEIF(NOT WIN32)
if(CMAKE_INSTALL_MANDIR)
SET(INSTALL_MANDIR ${CMAKE_INSTALL_MANDIR})
ELSE(CMAKE_INSTALL_MANDIR)
Expand Down