Fix #7582 Carla breaking GUI on Wayland#7966
Merged
messmerd merged 3 commits intoLMMS:masterfrom Jul 7, 2025
Merged
Conversation
1 task
michaelgregorius
approved these changes
Jul 6, 2025
Contributor
michaelgregorius
left a comment
michaelgregorius
left a comment
There was a problem hiding this comment.
I have tested this and it fixes the problem.
messmerd
approved these changes
Jul 7, 2025
Member
messmerd
left a comment
messmerd
left a comment
There was a problem hiding this comment.
Tested on X11 and there don't seem to be any regressions
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit #7453, the
updateInstrumentView()method has been called before the subwindow widget had been added (likely by mistake), causing plugins such as Carla to break the UI completely on Wayland: #7582Switching the order of the two lines fixed the issue without breaking the scalability feature of SlicerT introduced in the aforementioned commit. The result can be seen here:
https://github.com/user-attachments/assets/ff27c0f5-3d10-4237-b1b2-f6b0d5deb094
The changes were also tested while running XWayland, but more testing on X11 might be required.
This does not fix the issue of repeating backgrounds: #7798