Skip to content

Fixed missing emails in the author section. #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renderman21 wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fixed missing emails in the author section. #7975

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fbc491c
Convert author email to the correct format
renderman21 Jun 21, 2025
f75b866
Merge branch 'LMMS:master' into author_email
renderman21 Jun 23, 2025
8eab541
Fixed email formatting and able to show email
renderman21 Jun 25, 2025
e9d0107
Added conditional statements to replace specific author's emails with…
renderman21 Jun 25, 2025
01a60f6
Removed unnecessary lines
renderman21 Jun 25, 2025
20a12d1
Merge branch 'LMMS:master' into author_email
renderman21 Jun 28, 2025
08243cf
Simplified solution on LadspaSubPluginFeatures
renderman21 Jul 3, 2025
e303058
Delete missing space
rubiefawn Nov 12, 2025
02d5e80
Add QSizePolicy::Expanding to plugin description text
rubiefawn Nov 12, 2025
886b812
Change LADSPA plugin description format
rubiefawn Nov 12, 2025
8534079
Use `QString::arg()` instead of concatenation
rubiefawn Nov 13, 2025
5449d6e
Give EffectSelectDialog the same treatment
rubiefawn Nov 13, 2025
fb33dd0
Remove GUI display for LADSPA in-place broken
rubiefawn Feb 7, 2026
93a544f
Move markup inside translation strings
rubiefawn Mar 13, 2026
5f7e5ad
Put markup in translation strings (again)
rubiefawn Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions plugins/LadspaEffect/LadspaSubPluginFeatures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,33 @@ void LadspaSubPluginFeatures::fillDescriptionWidget( QWidget * _parent,
maker_label->setText( QWidget::tr( "Maker: " ) );
maker_label->setAlignment( Qt::AlignTop );
auto maker_content = new QLabel(maker);
maker_content->setText( lm->getMaker( lkey ) );

auto makerString = lm->getMaker(lkey).toHtmlEscaped();

makerString.replace("&lt;", "<");
makerString.replace("&gt;", ">");
makerString.replace("&amp;", "&");

if (makerString.contains("Andy Wingo"))
{
int startString = makerString.indexOf("<");
int endString = makerString.indexOf(">");
makerString.replace(startString + 1, endString - startString - 1, "wingo@pobox.com");
}

if (makerString.contains("Jesse Chappel"))
{
int startString = makerString.indexOf("<");
int endString = makerString.indexOf(">");
makerString.replace(startString + 1, endString - startString - 1, "jesse@essej.net");
}

maker_content->setTextFormat(Qt::PlainText);
maker_content->setText(makerString);
maker_content->setWordWrap( true );
l->addWidget( maker_label );
l->addWidget( maker_content, 1 );
l->addWidget( maker_content);


auto copyright = new QWidget(_parent);
l = new QHBoxLayout( copyright );
Expand Down
7 changes: 6 additions & 1 deletion src/gui/modals/EffectSelectDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,12 @@ void EffectSelectDialog::rowChanged(const QModelIndex& idx, const QModelIndex&)
auto label = new QLabel(m_descriptionWidget);
QString labelText = "<p><b>" + tr("Name") + ":</b> " + QString::fromUtf8(descriptor.displayName) + "</p>";
labelText += "<p><b>" + tr("Description") + ":</b> " + qApp->translate("PluginBrowser", descriptor.description) + "</p>";
labelText += "<p><b>" + tr("Author") + ":</b> " + QString::fromUtf8(descriptor.author) + "</p>";

QString authorString = QString::fromUtf8(descriptor.author).toHtmlEscaped();
authorString.replace("/dot/", ".");
authorString.replace("/at/", "@");

labelText += "<p><b>" + tr("Author") + ":</b> " + authorString + "</p>";

label->setText(labelText);
label->setWordWrap(true);
Expand Down
Loading