Add search bar for the soundfont player#8193
Conversation
|
Done with the code review. Just increase the |
|
Also, to add, I set However, when you open the selection dialogue, it always selects the first item, so If you know setting it to |
|
You're right about As for the row height, just updated it as well. I think I used a smaller value to try and align the bank list items (and to be fair, it doesn't even really do that), but making text readable is of higher priority. |
bratpeki
left a comment
There was a problem hiding this comment.
Approved for code and testing.
messmerd
left a comment
There was a problem hiding this comment.
I started this review a couple weeks ago but didn't submit it for some reason. So here it is.
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
|
Suggestions applied! And I did a bit more refactoring. |
The goal of this PR is to make searching for patches easier in the built-in soundfont player.

With this PR selecting a patch should be made easier, and at least for the first bank you can pretty much do most of it with just the keyboard (e.g. to pick patch "Shamisen", open the dialog, type "Sha", press enter, and you're good to go).
Closes #8023.
To-do list:
This PR is ready for review!