Skip to content

Fix Pitch Bending, Strum, and Knife Tools Affecting Per-Note Velocity/Panning #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
messmerd merged 1 commit into from
Feb 1, 2026
+4 −5
Merged

Fix Pitch Bending, Strum, and Knife Tools Affecting Per-Note Velocity/Panning #8243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2501,18 +2501,17 @@ void PianoRoll::mouseMoveEvent( QMouseEvent * me )
{
updateKnifePos(me, false);
}
if (m_editMode == EditMode::Detuning && (m_parameterEditDownLeft || m_parameterEditDownRight))
else if (m_editMode == EditMode::Detuning && (m_parameterEditDownLeft || m_parameterEditDownRight))
{
// Update the current dragging/adding/removal of automation nodes in the detuning curves of the selected notes.
updateParameterEditPos(me, Note::ParameterType::Detuning);
}
// Update Strum position if we are on knife mode
if (m_editMode == EditMode::Strum && m_strumEnabled)
// Update Strum position if we are in strum mode
else if (m_editMode == EditMode::Strum && m_strumEnabled)
{
updateStrumPos(me, false, me->modifiers() & Qt::ShiftModifier);
}

if (pos.y() > PR_TOP_MARGIN || m_action != Action::None)
else if (pos.y() > PR_TOP_MARGIN || m_action != Action::None)
{
bool edit_note = (pos.y() > noteEditTop())
&& m_action != Action::SelectNotes;
Expand Down
Loading