-
Notifications
You must be signed in to change notification settings - Fork 68
Add coq.univ.alg-super, @keep-alg-univs! #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is LPCIC#585 rebased on master. Co-Authored-By: Enrico Tassi <[email protected]> Co-Authored-By: Enzo Crance <[email protected]> Co-Authored-By: Cyril Cohen <[email protected]>
gares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
|
Are the docker CI expected to fail? |
|
Before merging I would just like a constructive proof that this is enough to port Trocq to modern Coq/Rocq versions ;) |
I think the failures originate from a warning being treated as an error in
This should be easy to fix. |
|
Even if not enough, this change is OK on my side. I would not let it bitrot |
|
alright, then merge first and check Trocq later on |
This is #585 rebased on master.
This should close both #585 and #400.