Conversation
|
I got Claude to update the rest of the files at https://github.com/JasonGross/coq-elpi/tree/v3.3.1%2Bqvar (188450b). The only possibly-questionable thing I noticed was that it changed I am also running into some performance issues recompiling rocq-mathcomp-field (in fieldext.v), though I'm not sure if they are a result of this change or some other patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After today's call I realized that the Rocq's
Context.binder_annotare converted into Elpi'snamedropping relevance, and the other way back setting it toRelevant. This PR keeps the relevance if given, or uses a relevance/quality variable if not.TODO:
CC @mattam82 @CohenCyril @tabareau