Fix NewRemoteSwitch examples to fully support ESPs#90
Open
latchdevel wants to merge 1 commit intoLSatan:masterfrom
Open
Fix NewRemoteSwitch examples to fully support ESPs#90latchdevel wants to merge 1 commit intoLSatan:masterfrom
latchdevel wants to merge 1 commit intoLSatan:masterfrom
Conversation
All examples works properly on any Arduino AVR, ESP8266 or ESP32. NewRemoteSwitch library commit c3ca4cb (Sep 19, 2021) or later, required to work on ESP8266 and ESP32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!.
After fixing some issues in NewRemoteSwitch library, including full support for ESP8266 and ESP32, it is necessary to update SmartRC-CC1101-Driver-Lib usage examples.
I have taken the opportunity to add some improvements and corrections, mainly for ESP8266, since it not works correctly direct switch from TX to RX mode, being necessary to previously go through the Idle mode. TX -> Idle -> RX. It only occurs to me that it is because in ESP8266 only GPIO 4 and 5 are available, which overlap with the I2C bus and most of the boards put these lines in pull-up.
I have tested the five examples in a real environment, both on Arduino AVR as ESP8266 and ESP32, all working correctly.
Hope I can help other users with my little contribution.
Regards!