include LWJGL's manifest in the shaded uber jar#41
Open
chirontt wants to merge 1 commit intoLWJGL:mainfrom
Open
include LWJGL's manifest in the shaded uber jar#41chirontt wants to merge 1 commit intoLWJGL:mainfrom
chirontt wants to merge 1 commit intoLWJGL:mainfrom
Conversation
so that the LWJGL's build number is shown properly in debug output of the shaded uber jar.
httpdigest
force-pushed
the
main
branch
25 times, most recently
from
ff1713f to
a35f8c5
Compare
httpdigest
force-pushed
the
main
branch
2 times, most recently
from
4131b94 to
3ef47ae
Compare
httpdigest
force-pushed
the
main
branch
3 times, most recently
from
6127460 to
6717e49
Compare
httpdigest
force-pushed
the
main
branch
10 times, most recently
from
eafcf00 to
492ad16
Compare
httpdigest
force-pushed
the
main
branch
2 times, most recently
from
86d8b54 to
bdb5675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that the LWJGL's build number is shown properly in debug output
of the shaded uber jar.
This would fix the following debug output which displays the LWJGL's build number like:
[LWJGL] Version: 3.3.0 SNAPSHOTwhich is wrong, to the correct build number string as specified in the LWJGL's manifest file:
[LWJGL] Version: 3.3.0 build 18The build number is quite important to LWJGL, as this string is used in the path to the temporary directory where LWJGL caches its native files such as
.dll,.so, etc., for re-use. If the build number string is always SNAPSHOT, due to the relevant info missing in the uber jar's manifest file for this project, then the LWJGL library would run the risk of re-using older natives (and potentially incorrect natives) from the cache at runtime, causing mysterious crashes.