CLI Feature. #1
Closed
CLI Feature. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split AboutView into smaller private views for better readability and maintainability. - Removed AppConfiguration class as its functionality is now handled by Core API. - Introduced AppDelegate for handling application lifecycle and URL schemes. - Updated ContentView to display auto-lock status when enabled. - Modified DependencyFactory to remove configuration dependency from KeyboardLockManager. - Enhanced KeyboardLockManager to utilize Core API for keyboard locking and unlocking. - Updated SettingsView to reflect changes in configuration management. - Improved notification handling in NotificationManager. - Cleaned up unused code and improved overall structure for better clarity and performance.
…cking functionality - Added ContentViewState to manage keyboard lock state and timed lock options. - Created LockControlView for main lock button and timed lock options. - Introduced PermissionView to handle accessibility permission requests. - Updated SettingsView to use new CoreConfiguration.Duration type. - Added SharedComponents for reusable UI elements like headers and setting rows. - Implemented StatusView to display current keyboard lock status and auto-lock information. - Developed TimedLockView for managing timed lock controls and custom durations. - Enhanced localization strings for new features and improved translations. - Updated main.swift with a TODO for future CLI implementation of KeyboardLocker.
…nagement - Removed initialization code from KeyboardLockerApp for IPC and exception handling. - Introduced new extensions for CGFloat, Duration, and TimeInterval to manage UI dimensions and duration formatting. - Consolidated duration management logic into CoreConfiguration.Duration with preset collections for timed and auto-lock durations. - Deleted redundant CountdownFormatter and LockDurationHelper classes, streamlining duration handling. - Updated NotificationManager to handle keyboard status notifications more efficiently. - Simplified UI components in ContentViewState and TimedLockView, removing unnecessary timers and headers. - Enhanced PermissionView layout and added quit button functionality. - Improved SettingsView and SharedComponents for better navigation and user experience. - Removed unused localization keys related to countdown and duration descriptions.
Owner
Author
|
@copilot review the changes. |
|
@LZhenHong I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 41 out of 42 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
KeyboardLocker/Sources/Helpers/URLHandler.swift:1
- Unused import statement. The
AppKitimport at line 1 is not used in this file. The file only uses types fromCoreandSwiftUI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CLI feature.