tests: longer Qemu startup timeout#81
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 58.88% 59.19% +0.30%
==========================================
Files 19 19
Lines 5833 5833
==========================================
+ Hits 3435 3453 +18
+ Misses 2398 2380 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/qemu/munet-cloud.yaml
Outdated
| # user: "root" | ||
| # password: "foobar" | ||
| # timeout: 3600 | ||
| timeout: 3600 |
There was a problem hiding this comment.
Isn't the current default 60 seconds? When you need the larger value what is the actual time that is taken?
It seems this test was mostly passing before so maybe we can increase the value more conservatively, even 10 times longer is 600 (i.e., 10 minutes), going from 1 minute to 1 hour seems like a pretty huge leap :)
There was a problem hiding this comment.
A more conservative increase should be fine. The current default ended up being more or less was equal to the actual startup time (hence the observed failures when it took a little longer than usual).
Sets the console timeout values of multiple tests as 600 sec. This prevents premature failures from being thrown within the github CI. Signed-off-by: Liam Brady <lbrady@labn.net>
f36d537 to
e4383c4
Compare
Increase the console timeout values of multiple tests. This prevents premature failures from being thrown within the github CI.
Note: I ran the github CI ~8 times on my munet fork with no recorded timeout-related issues.