Skip to content

[PLT-1957] Removed duplicate keys #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

[PLT-1957] Removed duplicate keys #1914

merged 1 commit into from
Nov 20, 2024

Conversation

@Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Nov 20, 2024

Description

  • Some of the fixtures had duplicate keys which could cause some issues
  • Remove the keys and add on to the linter to catch these cases in the future

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner November 20, 2024 15:33
@Gabefire Gabefire merged commit 63b136a into develop Nov 20, 2024
17 of 23 checks passed
@Gabefire Gabefire deleted the gu/remove_duplicate_keys branch November 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vbrodsky vbrodsky vbrodsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gabefire @vbrodsky