Open
Conversation
|
@diegovelezg este pull request pasa. |
perezju
reviewed
Dec 22, 2017
| @@ -0,0 +1,23 @@ | |||
|
|
|||
| function isValidCard(cardNumber) { | |||
| var string = cardNumber.toString(); | |||
There was a problem hiding this comment.
nit: string es un nombre muy genérico para tu variable, quizá cardNumberString queda mejor?
| cardNumber === parseInt(prompt('Ingrese el número de su tarjeta de crédito')); | ||
| var cardlength = string.length; | ||
| var sum = 0; | ||
| for (var i = 0; i < cardlength; i = i + 2) { |
There was a problem hiding this comment.
los dígitos se deben contar de derecha a izquierda, para corregirlo habría que invertir la cadena antes de empezar los ciclos for.
| var cardlength = string.length; | ||
| var sum = 0; | ||
| for (var i = 0; i < cardlength; i = i + 2) { | ||
| var numbers = (string.charAt(i)) * 2; |
There was a problem hiding this comment.
nit: numbers en realidad contiene un sólo número, sería mejor llamarlo number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.