Función Card Validation de María Alejandra Cabrera Pérez#55
Open
AlejandraCP wants to merge 1 commit intoLaboratoria-learning:masterfrom
Open
Función Card Validation de María Alejandra Cabrera Pérez#55AlejandraCP wants to merge 1 commit intoLaboratoria-learning:masterfrom
AlejandraCP wants to merge 1 commit intoLaboratoria-learning:masterfrom
Conversation
cm6n
reviewed
Dec 26, 2017
| for (var i = 0; i < numberCard.length; i++) { | ||
| // Si el elemento es igual a un string vacio aparece nuevo prompt. | ||
| // Si el elemento es NaN aparece nuevo prompt. | ||
| if (numberCard[i] === ' ' || isNaN(numberCard[i])) { |
There was a problem hiding this comment.
Es buen idea verificar que es un numero y esto cubre casi todos los casos, pero todavia permite "+" y "-" porque "-9" es un numero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hola, le mando mi código de la función para validar un número de tarjeta de crédito.
De ante mano muchas gracias por su tiempo, sus observaciones me ayudarán mucho.
Saludos.