Skip to content

Conversation

@Kallecrafter
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/brickcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/brickcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/brickcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/brickcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/brickcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Comment on lines 9 to 13
"discord": "https://discord.gg/ThCt8Pq",
"teamspeak": "craftergang.de",
"tiktok": "craftergang",
"youtube": "https://www.youtube.com/@craftergang",
"instagram": "craftergang"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that these are your social profiles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file has to be named [email protected]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor Author

@Kallecrafter Kallecrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor Author

@Kallecrafter Kallecrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 9 to 13
"discord": "https://discord.gg/ThCt8Pq",
"teamspeak": "craftergang.de",
"tiktok": "craftergang",
"youtube": "https://www.youtube.com/@craftergang",
"instagram": "craftergang"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

"skypvp": {
"name": "SkyPvP",
"color": "#0d6914",
"command": "/spawn",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not really a command to "join" the gamemode?

@Kallecrafter Kallecrafter requested a review from DoJapHD November 19, 2024 19:35
@DoJapHD DoJapHD merged commit a443ec1 into LabyMod:master Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants