Skip to content

Conversation

@FerHdzG
Copy link

@FerHdzG FerHdzG commented Dec 21, 2025

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately
  • I have created the manifest.json with the required values

Further comments

First submission for LunaticMC.

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.
  • Wildcard %.lunaticmc.com seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use valid format (ISO 3166-1 alpha-2) for country code. (location.country_code)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@FerHdzG
Copy link
Author

FerHdzG commented Dec 21, 2025

All requested changes have been fixed.
Validate Images and Manifest are now passing.
Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

"nice_name": "LunaticMC Network",
"direct_ip": "lunaticmc.net",
"server_wildcards": [
"%.lunaticmc.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"es"
],
"social": {
"web": "https://lunaticmc.net",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connection not secure and is only a redirect

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@github-actions
Copy link

Just as an information regarding your wildcards:

  • Wildcard %.lunaticmc.net seems to be invalid. Server is offline with testing wildcard.

Please make sure it is an actual wildcard.

@github-actions
Copy link

Just as an information:

@FerHdzG
Copy link
Author

FerHdzG commented Dec 23, 2025

Done and fixed. I await your review.

Thank you.

@FerHdzG FerHdzG requested a review from DoJapHD December 23, 2025 03:06
@DoJapHD
Copy link
Collaborator

DoJapHD commented Dec 23, 2025

Server seems not yet to be released
Open another PR once server is publicly available

@DoJapHD DoJapHD closed this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants