This repository was archived by the owner on Dec 25, 2022. It is now read-only.
CMake: Set macOS deployment options on ladybird to quiet Xcode#98
Open
ADKaster wants to merge 3 commits intoLadybirdBrowser:masterfrom
Open
CMake: Set macOS deployment options on ladybird to quiet Xcode#98ADKaster wants to merge 3 commits intoLadybirdBrowser:masterfrom
ADKaster wants to merge 3 commits intoLadybirdBrowser:masterfrom
Conversation
When using the Xcode generator, Xcode complains about a mismatch between CMake and the plist file for the application name. It also complains that we're not using codesign properly, so just disable codesign altogether.
linusg
suggested changes
Oct 17, 2022
The include directories were only required for a brief period when ladybird was compiling IPC itself. That has since been moved to the Lagom build in serenity.
ADKaster
force-pushed
the
macos-build-and-cleanup
branch
from
ba989ac to
8c43aa5
Compare
For the build directory only, copy WebContent next to ladybird and add a symlink to the source dir into Content/Resources/ of ladybird.app. This allows building and running ladybird in Xcode and Instruments, as long as the SERENITY_SOURCE_DIR is set in the ladybird scheme.
ADKaster
force-pushed
the
macos-build-and-cleanup
branch
from
c40654e to
fbc1d11
Compare
linusg
reviewed
Oct 18, 2022
Contributor
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
First commit says "CMake", the other two "cmake" - rest LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the Xcode generator, Xcode complains about a mismatch
between CMake and the plist file for the application name.
It also complains that we're not using codesign properly, so just
disable codesign altogether.
Note that actually using -GXcode for cmake won't work without SerenityOS/serenity#15659