Tests/LibWeb: Improve flaky iframe srcdoc crash test#8932
Closed
gmta wants to merge 1 commit intoLadybirdBrowser:masterfrom
Closed
Tests/LibWeb: Improve flaky iframe srcdoc crash test#8932gmta wants to merge 1 commit intoLadybirdBrowser:masterfrom
gmta wants to merge 1 commit intoLadybirdBrowser:masterfrom
Conversation
awesomekling
approved these changes
Apr 16, 2026
Collaborator
Author
|
Relevant comment by @kalenikaliaksandr :
|
This test was introduced in b64df59 but had a race condition where `contentDocument.body` would not yet be available. Switch to an async test that listens to the iframe's `load` event before continuing. Confirmed that this still crashes without the original fix.
gmta
force-pushed
the
tests-libweb-set-innerhtml-flake
branch
from
763fd42 to
1f3ae83
Compare
Collaborator
Author
|
Closing this; I believe something closer to #8852 is going to be a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was introduced in b64df59 but had a race condition where
contentDocument.bodywould not yet be available. Switch to an async test that listens to the iframe'sloadevent before continuing. Confirmed that this still crashes without the original fix.Flakes on master seen here: