AK: Avoid some overflow conditions in Duration's rational conversions#8936
Merged
Zaggy1024 merged 2 commits intoLadybirdBrowser:masterfrom Apr 16, 2026
Merged
Conversation
Overflow could happen in the multiplication of the remainder seconds back into time units. Instead, take a remainder of the time units from the division and use that for the nanoseconds.
With numerators or denominators approaching NumericLimits<u32>::max(), we could overflow in the sum of the remainder and the rounding contribution. Instead, divide them separately and sum them afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few situations where these could allow unchecked overflows. I've fixed those cases and added some tests for them.