Add glove_skin custom property for extracting glove skin names#303
Merged
LaihoE merged 1 commit intoLaihoE:mainfrom Jan 6, 2026
Merged
Add glove_skin custom property for extracting glove skin names#303LaihoE merged 1 commit intoLaihoE:mainfrom
LaihoE merged 1 commit intoLaihoE:mainfrom
Conversation
- Add find_glove_skin() function to extract glove skin names from PAINTKITS - Add GLOVE_SKIN constant (ID: 20000003) to prop_controller - Register glove_skin in PropType map, FRIENDLY_NAMES_MAPPING, and CUSTOM_PLAYER_PROP_IDS - Add error variants: GloveSkinFloatConvertionError, GloveSkinIdxIncorrectVariant, GloveSkinNoSkinMapping This allows parse_ticks(['glove_skin']) to return actual glove skin names like 'Imperial Plaid', 'Polygon', 'Amphibious' etc., matching the existing weapon_skin functionality.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary
Adds
glove_skinas a new custom property toparse_ticks(), enabling extraction of glove skin names directly from demo files.## Motivation
Currently, glove data fields (
glove_paint_id,glove_paint_seed,glove_paint_float) are available, but there's no way to get the actual glove skin name (e.g., "Imperial Plaid", "Polygon"). This PR addsglove_skinto match the existingweapon_skinfunctionality.## Changes
GLOVE_SKINconstant (ID: 20000003)glove_skinin:CUSTOM_PLAYER_PROP_IDSmapFRIENDLY_NAMES_MAPPINGmapPropTypeenum mappingfind_glove_skin()function that performs PAINTKITS lookup## Usage Example
## Testing
Tested on a cs2 replay and it worked for me :)
## Implementation Note
The glove_skin field performs a PAINTKITS lookup based on glove_paint_id. Users should check glove_item_idx > 0 in their code to distinguish between players actively wearing custom gloves versus those with default gloves (as players may have a paint_id in inventory without wearing custom gloves).