fix: restore player metadata sync in gather_extra_info()#315
Merged
LaihoE merged 1 commit intoLaihoE:mainfrom Feb 22, 2026
Merged
fix: restore player metadata sync in gather_extra_info()#315LaihoE merged 1 commit intoLaihoE:mainfrom
LaihoE merged 1 commit intoLaihoE:mainfrom
Conversation
Re-add player metadata population block that was removed in LaihoE#311, fixing stale self.players causing null victims, wrong side attribution, and missing player rounds on overtime demos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gather_extra_info()that was removed in Mega bugfix #311, fixing a v0.41.0 regression on overtime demosself.playerswhen fullpackets are skipped or delta updates don't triggerPlayerConnecteventshandle_player_connect()is kept as-is (the redundantself.players.insert()is idempotent)Fixes #314
Test plan
cargo buildcompiles cleanlycargo test— all 333 tests passvictim_name/victim_steamidattacker_side != victim_sidefilter gives expected ADR)🤖 Generated with Claude Code