Clean Up and Migration to PanUpdate #31
Open
+41
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
left padding aligns with widget but disallows any width restrictions of parent widget because calculates off Screen.
Because the updates were limited to onVerticalDragUpdate, the list could lock up when a user tapped down and started to drag horizontally. So onPanUpdate is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of only using onVerticalDragUpdate, when a user would tap down and drag horizontally, the list would lock up.
Using onPan instead of vertical/horizontal is preferred. Also updated a dependency centered the list.
Note: Centering might not be preferred, I am fine to remove that, or perhaps preferably add as a toggle, I just doubt anyone is maintaining this to accept the pull, so I left it in for now.