-
Notifications
You must be signed in to change notification settings - Fork 0
Code Review
Jason Brown edited this page Jan 19, 2023
·
7 revisions
-
Login navigates to destination
-
LoginUser makes backend requests
-
logged in, show some registered user functionality
-
App
Search
- how many results
- account create based on RateMyProf - create as tenant or landlord
- add city
- Change all components to functional components (e.g. App component)
- Update to react 18 render syntax - createRoot, etc.
- App opens to the dashboard/ search page - change route to redirect user to login
- Review routes and conditional rendering - can refactor to make routes dynamic based off of user authentication status
Get rid of multiple state - form is not receiving correct value input from state data for email and password
- Currently not customized to the individual user experience - same list is populating regardless of user. This will require:
- Ensuring user id is populated to landlord/review in the db and querying for that individual’s landlords / reviews
- logout functionality - ensure that it goes back to sign in page
- change search functional component to make uniform with rest of codebase
- input not receiving visible values
- edit search functionality to handle uppercase letters
- currently search functionality runs in o(n*m) - is there a way we can edit the search for a better time complexity/optimization?
- Render text (e.g. no landlords match current search) if filter does not render a particular landlord
- create a separate search page with google map api to select landlord reviews within a particular area
Create form for location (e.g. address and drop down for state, area code, etc.)
- separate middleware into separate controllers for modularity/readability and better maintainability
- handle promises either using async/await or .then
- Cache main dashboard data and landlord card specifics
- check db to see if landlords are connected to user ids - need this to ensure we populate lists according to user profile