Show number of voters in poll and small enhancement for sub page.#114
Open
sometimesok wants to merge 10 commits intoLanny:masterfrom
Open
Show number of voters in poll and small enhancement for sub page.#114sometimesok wants to merge 10 commits intoLanny:masterfrom
sometimesok wants to merge 10 commits intoLanny:masterfrom
Conversation
pull latest
…delimiter username
Lanny
requested changes
Aug 29, 2021
Comment on lines
+237
to
+239
| for post in Post.objects.all(): | ||
| post.content = post.content.replace("author=\"" + self.username + "\"", "author=\"" + str(other) + "\"") | ||
| post.save() |
Owner
There was a problem hiding this comment.
I know people don't like having their usernames hang out in quotes, but we can't do this for two reasons:
- On a policy/moral level this edits posts belonging to people other than the person anonymizing themselves. Editing other peoples posts is a right reserved for the tyrant (me)
- Iterating over every post in the DB, doing a string substitution, and writing back to the DB is going to clobber the DB. On NiS prod the select query probably won't even finish before we run out of memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.