Add option to switch authentication guards #141

jorenvanhee · 2017-05-02T11:58:07Z

This fixes #122.

I basically made it possible to switch authentication guards for backpack. This makes it possible to use a different guard besides the default one (from config/auth.php).

For instance, you have a guard for the users on the public facing part of the website. And you have a different guard for the admins of the website. So a user guard and an admin guard. If the user guard is the default one, then it was impossible to use the admin guard with backpack. This pull request makes it possible to set a specific guard for backpack.

There was already a config option user_model_fqn in backpack, but this only changed the behaviour of the user registration. More info about that in issue #122.

This should be a non-breaking change because the user_model_fqn config option is still present and being used. We could remove it and fetch the used model from the guard configuration, but that would be a breaking change.

This is a breaking change because the views are different now, and they have to be republished. Since it is a breaking change, I will also look into removing the user_model_fqn option.

Actually, the views only need to be republished, if you use the new guard option. The old views just use the default guard. So I'm not sure if this is breaking or not...

soham2008xyz · 2017-05-03T03:13:36Z

Have you seen #87? Exactly similar to our use case here, hasn't been merged yet.

lloy0076 · 2017-06-04T04:01:23Z

@soham2008xyz @jorenvanhee - it seems that #87 is similar but not quite the same although I do agree that they are probably addressing the same issue.

I think the main point of difference is that 87 includes the guard whereas this one doesn't.

lloy0076 · 2017-06-04T04:02:28Z

src/app/Http/Controllers/Auth/ForgotPasswordController.php

+    public function broker()
+    {
+        $passwords = config('backpack.base.passwords')
+            ?: config('auth.defaults.passwords');


lloy0076 · 2017-06-04T04:03:33Z

src/app/Http/Controllers/Auth/RegisterController.php

    {
-        $this->middleware('guest');
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:03:43Z

src/app/Http/Controllers/Auth/RegisterController.php

        return redirect($this->redirectPath());
    }
+
+    protected function guard()


lloy0076 · 2017-06-04T04:03:51Z

src/app/Http/Controllers/Auth/RegisterController.php

+    protected function guard()
+    {
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:04:05Z

src/app/Http/Controllers/Auth/ResetPasswordController.php

    {
-        $this->middleware('guest');
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:04:53Z

src/app/Http/Controllers/Auth/ResetPasswordController.php

+    protected function guard()
+    {
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:05:13Z

src/app/Http/Middleware/Admin.php

+    public function handle($request, Closure $next)
    {
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:05:33Z

src/app/Http/ViewComposers/AuthComposer.php

+
+class AuthComposer
+{
+    public function compose(View $view)


lloy0076 · 2017-06-04T04:05:40Z

src/app/Http/ViewComposers/AuthComposer.php

+    public function compose(View $view)
+    {
+        $guard = config('backpack.base.guard')
+            ?: config('auth.defaults.guard');


lloy0076 · 2017-06-04T04:07:47Z

src/resources/views/inc/menu.blade.php

      <!-- <li><a href="{{ url('/') }}"><i class="fa fa-home"></i> <span>Home</span></a></li> -->

-        @if (Auth::guest())
+        @if ($backpackAuth->guest())


Where did $backpackAuth come from?

From the AuthComposer.

jorenvanhee · 2017-06-20T07:58:55Z

Is there something more that I can do to get this PR merged?

If this one gets merged, I will also have to update the authorize method in the CrudRequest class from Backpack/CRUD.

OwenMelbz · 2017-06-21T07:57:12Z

@jorenvanhee this looks like a duplicate of #87 which has had some discussion over.

tabacitu · 2017-07-06T06:55:08Z

@jorenvanhee - I'm sorry, I've been hacking away at client projects and preparing something super exciting for the Backpack community that will be revealed soon, so I haven't merged PRs for a while. But I'm back now!

@OwenMelbz - is this a complete replacement for #87? Cause if it is, I think I like it a bit better, and it would be a non-breaking change, so it's ready to test and merge. I especially like that:

it avoids using a helper;
the guard usage has better readability
@if ($backpackAuth->guest()) over @if (!backpack_admin()), because it allows you to call ->check() and other methods too;
the configuration file seems easier to understand to me (just replace the Auth middleware if you need to);
it falls back to configuration options from Laravel itself (config/auth.php);

Honestly, I think "pretty awesome" is the word for this PR :-)
Really nice job @jorenvanhee :-)

tabacitu · 2017-07-06T07:35:58Z

@jorenvanhee , @lloy0076 - I've merged this into a separate branch and done @lloy0076 's suggestions: #165

Let's move the conversation there, please.

tabacitu · 2017-09-12T07:27:23Z

Closing this - let's move the conversation there.

OwenMelbz · 2017-09-12T08:05:02Z

@tabacitu just this asking if its a replacement for the other PR - answer is no lol, it does not address the issues we face.

Regards to the comments of

it avoids using a helper;
the guard usage has better readability
@if ($backpackAuth->guest()) over @if (!backpack_admin()), because it allows you to call ->check() and other methods too;
the configuration file seems easier to understand to me (just replace the Auth middleware if you need to);
it falls back to configuration options from Laravel itself (config/auth.php);

Responses being

We've just introduced helpers - so that argument I assume is now void?
Not sure this one is entirely true :D even adds another dependency of passing data to the view which means more files will need to be updated for the user
The helper was designed to get the user instance - not query the guard - you can still do that
Again the issue was not that we want a custom guard - the issue is separation of sessions - you cannot be logged into only 1 without customly writing this yourself which adds annoying overheads.
The user can use the default guard if they want

jorenvanhee added 3 commits May 2, 2017 12:08

Make it possible to switch guards

ccbf8fb

Use correct guard in views

a592571

Fix order of use statements

2fd3f86

jorenvanhee changed the title ~~Different user model issue fix~~ Make it possible to switch authentication guards, fixes #122 May 2, 2017

jorenvanhee changed the title ~~Make it possible to switch authentication guards, fixes #122~~ Add option to switch authentication guards, fixes #122 May 2, 2017

jorenvanhee changed the title ~~Add option to switch authentication guards, fixes #122~~ Add option to switch authentication guard May 2, 2017

jorenvanhee changed the title ~~Add option to switch authentication guard~~ Add option to switch authentication guards May 2, 2017

Make the admin middleware use the backpack guard

08b9390

lloy0076 reviewed Jun 4, 2017

View reviewed changes

Laravel-Backpack deleted a comment from lloy0076 Jul 6, 2017

tabacitu mentioned this pull request Jul 6, 2017

[Feature][0.9][Merged] Custom auth guard #165

Merged

tabacitu closed this Sep 12, 2017

Add option to switch authentication guards #141

Add option to switch authentication guards #141

Uh oh!

Conversation

jorenvanhee commented May 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soham2008xyz commented May 3, 2017

Uh oh!

lloy0076 commented Jun 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorenvanhee commented Jun 20, 2017

Uh oh!

OwenMelbz commented Jun 21, 2017

Uh oh!

tabacitu commented Jul 6, 2017

Uh oh!

tabacitu commented Jul 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tabacitu commented Sep 12, 2017

Uh oh!

OwenMelbz commented Sep 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jorenvanhee commented May 2, 2017 •

edited

Loading

tabacitu commented Jul 6, 2017 •

edited

Loading