Skip to content
This repository was archived by the owner on Nov 23, 2020. It is now read-only.

Conversation

shirshak55
Copy link
Contributor

It is better for future than yield as in stack isn't it?

It is better for future than yield as in stack isn't it?
@lloy0076
Copy link
Contributor

@bloggervista

  1. I find stacks more intuitive
  2. Stacks are better than yield in the sense that one can push to them multiple times from different view templates

@tabacitu - do you have an opinion?

@shirshak55
Copy link
Contributor Author

@lloy0076
Your Point no 2 was exactly my thought :)

@shirshak55
Copy link
Contributor Author

@lloy0076 please don't merge this immediately merge it in next version. Because it may seem it will not change anything but it will affect backpack crud because i found backpack crud used @section('before_syles') like that. Before merging we need to make it backpack crud friendly right?

@lloy0076
Copy link
Contributor

lloy0076 commented Jun 6, 2017

@bloggervista - AFAICT one can use @stack and @section together but I'd be incline to suggest that the before_styles section be deprecated.

@shirshak55
Copy link
Contributor Author

@lloy0076 I also want them to be deprecated but i don't know this before_styles will ripple to other package like only crud or other packages only. I think we need to update that first. But it seems the author of this package is busy :(

@tabacitu
Copy link
Member

tabacitu commented Jun 8, 2017

@bloggervista , @lloy0076 - totally agree with you guys on the stack vs yield debate. The only reason we've used yield so far is because this project has started before "stacks" existed.

That being said, I definitely want to merge this, but it does represent a breaking change, so we need to time this just right. We made a point in bundling all breaking changes together, and launching them once Laravel itself launches another version. That way, Backpack developers only need to sit down and upgrade once: first Laravel, then Backpack.

So it should be another about 2 months until this gets merged and made public, sorry.

Cheers!

@shirshak55
Copy link
Contributor Author

@tabacitu Can we add latest feature in another branch?

@tabacitu
Copy link
Member

tabacitu commented Mar 8, 2018

@bloggervista , @lloy0076 - I think this was a great change. And now that 0.9 is almost ready for launch, I think it's a really good moment to introduce it. I haven't been able to merge this as the source of the PR is gone, but I've made a separate PR here #260 that has it, with a twist - it's now non-breaking.

Thanks a lot for this @bloggervista .
Cheers!

@tabacitu tabacitu closed this Mar 8, 2018
@shirshak55
Copy link
Contributor Author

shirshak55 commented Mar 8, 2018

Thanks tabacitu for this package :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants