-
Notifications
You must be signed in to change notification settings - Fork 271
Use Stacks instead of yield #152
Conversation
It is better for future than yield as in stack isn't it?
@bloggervista
@tabacitu - do you have an opinion? |
@lloy0076 |
@bloggervista - AFAICT one can use |
@lloy0076 I also want them to be deprecated but i don't know this before_styles will ripple to other package like only crud or other packages only. I think we need to update that first. But it seems the author of this package is busy :( |
@bloggervista , @lloy0076 - totally agree with you guys on the stack vs yield debate. The only reason we've used yield so far is because this project has started before "stacks" existed. That being said, I definitely want to merge this, but it does represent a breaking change, so we need to time this just right. We made a point in bundling all breaking changes together, and launching them once Laravel itself launches another version. That way, Backpack developers only need to sit down and upgrade once: first Laravel, then Backpack. So it should be another about 2 months until this gets merged and made public, sorry. Cheers! |
@tabacitu Can we add latest feature in another branch? |
@bloggervista , @lloy0076 - I think this was a great change. And now that 0.9 is almost ready for launch, I think it's a really good moment to introduce it. I haven't been able to merge this as the source of the PR is gone, but I've made a separate PR here #260 that has it, with a twist - it's now non-breaking. Thanks a lot for this @bloggervista . |
Thanks tabacitu for this package :) |
It is better for future than yield as in stack isn't it?