Skip to content

[4.0][Refactor][Ready] Rename CRUD::resource() to Route::crudResource() #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[4.0][Refactor][Ready] Rename CRUD::resource() to Route::crudResource() #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee1948
rename CRUD::resource to Route::crudResource
tabacitu Jul 13, 2019
33760e1
Apply fixes from StyleCI (#1933)
tabacitu Jul 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@
"laravel": {
"providers": [
"Backpack\\CRUD\\CrudServiceProvider"
],
"aliases": {
"CRUD": "Backpack\\CRUD\\CrudServiceProvider"
}
]
}
}
}
13 changes: 8 additions & 5 deletions src/CrudServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Backpack\CRUD;

use Illuminate\Support\Facades\Route;
use Illuminate\Support\ServiceProvider;

class CrudServiceProvider extends ServiceProvider
Expand Down Expand Up @@ -91,6 +92,13 @@ public function register()
return new CRUD($app);
});

// add the Route::crudResource() macro for developers to set all CRUD routes in one line
if (! Route::hasMacro('crudResource')) {
Route::macro('crudResource', function ($name, $controller, array $options = []) {
return new CrudRouter($name, $controller, $options);
});
}

// register the helper functions
$this->loadHelpers();

Expand All @@ -103,11 +111,6 @@ public function register()
}
}

public static function resource($name, $controller, array $options = [])
{
return new CrudRouter($name, $controller, $options);
}

/**
* Load the Backpack helper methods, for convenience.
*/
Expand Down