Skip to content

fix: getCurrentEntryId() should return null instead of false #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: getCurrentEntryId() should return null instead of false #5416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/Library/CrudPanel/Traits/Read.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ trait Read
/**
* Find and retrieve the id of the current entry.
*
* @return int|bool The id in the db or false.
* @return int|null The id in the db or null.
*/
public function getCurrentEntryId()
{
Expand All @@ -29,7 +29,7 @@ public function getCurrentEntryId()
// otherwise use the next to last parameter
array_values($params)[count($params) - 1] ??
// otherwise return false
false;
null;
}

/**
Expand Down