Skip to content

[v7] Reorder HasForm trait parameters #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[v7] Reorder HasForm trait parameters #5459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0076d4
reorder form trait parameters
pxpm Mar 1, 2024
b311593
Apply fixes from StyleCI
StyleCIBot Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/Http/Controllers/Operations/Concerns/HasForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public function formView(?int $id = null): \Illuminate\Contracts\View\View
*
* @return array|\Illuminate\Http\RedirectResponse
*/
public function formAction(?int $id = null, callable $formLogic)
public function formAction(callable $formLogic, ?int $id = null)
{
if ($id) {
// Get entry ID from Request (makes sure its the last ID for nested resources)
Expand Down