DataFormModal component #5863
DataFormModal component #5863
Conversation
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
…into modal-form # Conflicts: # src/CrudPanelManager.php
[ci skip] [skip ci]
src/resources/views/crud/components/dataform/modal-form.blade.php
Outdated
Show resolved
Hide resolved
|
|
||
| @stack('after_styles') | ||
|
|
||
| <script> |
There was a problem hiding this comment.
Let's move these to a global js
[ci skip] [skip ci]
| $controller->initializeCrudPanel($primaryControllerRequest, $crud); | ||
|
|
||
| // If the panel isn't initialized at all, do full initialization | ||
| if (! $crud->isInitialized()) { |
There was a problem hiding this comment.
Something here smells a bit - maybe we can return early or smth
src/resources/views/crud/components/dataform/modal-form.blade.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
quick cleanup pls - indentation etc
There was a problem hiding this comment.
Please test the field stacks - try to push some widgets to before_content and after_content
| public function __construct( | ||
| public string $controller, | ||
| public string $id = 'backpack-form', | ||
| public string $operation = 'create', |
There was a problem hiding this comment.
Let's make sure we can also call a custom form operation. (not urgent)
There was a problem hiding this comment.
| public string $operation = 'create', | |
| public string $formOperation = 'create', |
| public string $controller, | ||
| public string $id = 'backpack-form', | ||
| public string $operation = 'create', | ||
| public string $name = '', |
There was a problem hiding this comment.
| public string $name = '', |
[ci skip] [skip ci]
…into modal-form
[ci skip] [skip ci]
| data-has-upload-fields="{{ $hasUploadFields ? 'true' : 'false' }}" | ||
| data-refresh-datatable="{{ $refreshDatatable ? 'true' : 'false' }}" | ||
| > | ||
| <div class="text-center"> |
There was a problem hiding this comment.
Is there an elegant way for us to tell the form blade file to NOT use the card and card-body classes? Both the Dataform and DataformModal would benefit from this tiny change:
[ci skip] [skip ci]
[ci skip] [skip ci]
There was a problem hiding this comment.
Here's another round of testing. I discovered:
- quite a few fields don't work
select2s,browse - edit modal doesn't load the entry
- after an entry is created with DataFormModal, sometimes the datatable refreshes, sometimes it doesn't
Here's a 5-min tour of my experience:
https://www.loom.com/share/6bffaa54f65e4c7f8b4188e064ca0bb7
3 participants
In development, this introduces a form in a modal 🙏