add option to generate forms without id, use named parameters in formAction #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxpm
changed the title
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
I have the need to quickly generate forms that are not using id in routes.
Even if the "required change" is to make
routesHaveIdSegment: false, the generated Operation had alot of$idreferences when not needed, so they needed to manually cleaned.AFTER - What is happening after this PR?
One can use
--no-idto generate a form without $id parameter.The generated operation files will now on use named parameters on the
formActioncallback.This will also help in the fact that we need to do a breaking change in Laravel-Backpack/CRUD#5459 and people generating operations with the commands after this PR will not be affected.