Settings syncronization with config/settings.php #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------------------------------------------ Command settings:sync helps you keep production settings in sync with config/settings.php It doesn't override "value" field Package publishes config/settings.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings syncronization with config/settings.php
Command settings:sync helps you keep production settings in sync with
config/settings.php
It doesn't override "value" field
Package now publishes config/settings.php
Backwards compatiblity
What could go wrong?
If user upgrades to this version, then doesn't have any config/settings.php file and runs
php artisan settings:syncit'll use dummy settings in the package, removing user settings in their database.This is not a likely scenario of a cautious programmer running any command in production, but it'll be a good security check to have.
(I'm not sure how to check for config/settings.php in user code only)