Add support to use a CDN along with basset#151
Open
dkwiebe wants to merge 1 commit intoLaravel-Backpack:mainfrom
Open
Add support to use a CDN along with basset#151dkwiebe wants to merge 1 commit intoLaravel-Backpack:mainfrom
dkwiebe wants to merge 1 commit intoLaravel-Backpack:mainfrom
Conversation
Use an external CDN together with Basset
Member
|
Hello @dkwiebe, Thank you for sharing this PR. I’ll ask our Senior Developer to review it, and if everything looks good, he will confirm whether it can be merged. Thanks again! Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple change to configuration and code to simplify the use of an external CDN with basset. I'm using this together with AWS Cloudfront. We set the BASSET_CDN_URL to https://example.cloudfront.net. That allows us to use basset to collect all external files into our site and minimize our server traffic requirements at the same time.