Fix CacheMap when cache is corrupted#169
Open
villfa wants to merge 1 commit intoLaravel-Backpack:mainfrom
Open
Fix CacheMap when cache is corrupted#169villfa wants to merge 1 commit intoLaravel-Backpack:mainfrom
villfa wants to merge 1 commit intoLaravel-Backpack:mainfrom
Conversation
pxpm
requested changes
Mar 9, 2026
Contributor
pxpm
left a comment
There was a problem hiding this comment.
Thanks @villfa !
I agree we can gracefully handle the corrupt map files. Since we are changing it, I am tempted to use a more fool proof to handle other generic errors that might happen with the file read.
What you think ? Willing to do the changes in the PR ?
Cheers
13974da to
5524d8f
Compare
Author
|
BTW, would it be possible to cherry-pick this change and make a I won't be able to migrate to Backpack v7 for a few months, so it would be great to benefit from this fix in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The goal of this PR is to prevent errors of this sort:
I observed this error in very rare occasions so I'm not sure how to reproduce.