Merge pull request #63 from rumeau/patch-1

Modify Placeholder to not send data

Author: adamgoose

src/FormBuilder.php

@@ -642,6 +642,7 @@ protected function placeholderOption($display, $selected)
     $selected = $this->getSelectedValue(null, $selected);
 
     $options = compact('selected');
+    $options['value'] = '';
 
     return '<option' . $this->html->attributes($options) . '>' . e($display) . '</option>';
   }

tests/FormBuilderTest.php

@@ -322,15 +322,15 @@ public function testFormWithOptionalPlaceholder()
       null,
       ['placeholder' => 'Select One...']
     );
-    $this->assertEquals($select, '<select name="size"><option selected="selected">Select One...</option><option value="L">Large</option><option value="S">Small</option></select>');
+    $this->assertEquals($select, '<select name="size"><option selected="selected" value="">Select One...</option><option value="L">Large</option><option value="S">Small</option></select>');
 
     $select = $this->formBuilder->select(
       'size',
       ['L' => 'Large', 'S' => 'Small'],
       'L',
       ['placeholder' => 'Select One...']
     );
-    $this->assertEquals($select, '<select name="size"><option>Select One...</option><option value="L" selected="selected">Large</option><option value="S">Small</option></select>');
+    $this->assertEquals($select, '<select name="size"><option value="">Select One...</option><option value="L" selected="selected">Large</option><option value="S">Small</option></select>');
   }
 
   public function testFormSelectYear()