Compatibility with oder Android versions#17
Open
johan12345 wants to merge 2 commits intoLarsWerkman:masterfrom
Open
Compatibility with oder Android versions#17johan12345 wants to merge 2 commits intoLarsWerkman:masterfrom
johan12345 wants to merge 2 commits intoLarsWerkman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the NineOldAndroids library, I adjusted Lobsterpicker to work on older Android versions (I set the minSdk to 7, though it might work on even older versions). I tested it on and API 10 (Android 2.3.3) emulator and it seems to work.
Even though I could understand if you declined this PR due to the deprecated state of the NineOldAndroids library or due to the few KB of bloat it adds to the project, I think there are still many apps out there that need to support API 7+ and are thus not able to use your nice color picker in its current state. Supporting API 7+ would put this library on the same level as most of Google's Android Support Libraries.
In the process of integrating NineOldAndroids, I also updated the Android Gradle Plugin, compileSDK, targetSDK and support library versions to their newest versions, respectively.