sync: merge upstream v1.1.27 and fixes into integration #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+15
to
+31
| window.addEventListener("keydown", (event) => { | ||
| if (OS_NAME === "macos" ? event.metaKey : event.ctrlKey) { | ||
| if (event.key === "-") { | ||
| zoomLevel -= 0.2 | ||
| } else if (event.key === "=" || event.key === "+") { | ||
| zoomLevel += 0.2 | ||
| } else if (event.key === "0") { | ||
| zoomLevel = 1 | ||
| } else { | ||
| return | ||
| } | ||
| zoomLevel = Math.min(Math.max(zoomLevel, MIN_ZOOM_LEVEL), MAX_ZOOM_LEVEL) | ||
| invoke("plugin:webview|set_webview_zoom", { | ||
| value: zoomLevel, | ||
| }) | ||
| } | ||
| }) |
There was a problem hiding this comment.
logic: missing event.preventDefault() after line 25 to prevent default browser zoom behavior from conflicting with the custom webview zoom
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/desktop/src/webview-zoom.ts
Line: 15:31
Comment:
**logic:** missing `event.preventDefault()` after line 25 to prevent default browser zoom behavior from conflicting with the custom webview zoom
How can I resolve this? If you propose a fix, please make it concise.
|
Found 9 test failures on Blacksmith runners: Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
packages/desktop/packages/app/src/utils/persist.tspackages/app/src/pages/session.tsxpackages/ui/packages/opencode/src/cli/cmd/tui/Testing
Breaking Changes
None
Greptile Summary
Merges upstream v1.1.27 with several critical fixes for desktop zoom behavior, localStorage quota handling, and memory management.
Key improvements:
Ctrl/Cmd +/-/0)Changes verified:
Confidence Score: 4/5
event.preventDefault()which could cause conflicting zoom behaviors. All other changes are well-tested improvements from upstream.preventDefault()added to prevent default browser zoomImportant Files Changed
Sequence Diagram
sequenceDiagram participant User participant Desktop participant WebviewZoom participant LocalStorage participant PersistLayer participant Cache participant Session participant SyncContext User->>Desktop: Triggers zoom (Ctrl/Cmd + +/-) Desktop->>WebviewZoom: keydown event WebviewZoom->>WebviewZoom: Calculate new zoom level WebviewZoom->>Desktop: invoke set_webview_zoom User->>Session: Interacts with app Session->>PersistLayer: Save state PersistLayer->>Cache: Write to cache PersistLayer->>LocalStorage: Attempt write alt Quota exceeded LocalStorage-->>PersistLayer: QuotaExceededError PersistLayer->>LocalStorage: Evict oldest items PersistLayer->>LocalStorage: Retry write end alt Still exceeds quota LocalStorage-->>PersistLayer: Still fails PersistLayer->>PersistLayer: Disable localStorage, use cache only end User->>Session: Creates messages Session->>SyncContext: Store message parts SyncContext->>SyncContext: Check message count > 100 alt Too many messages SyncContext->>SyncContext: Remove oldest message SyncContext->>SyncContext: Delete associated parts from store end User->>Desktop: Closes/hides window Desktop->>PersistLayer: Flush all storage PersistLayer->>LocalStorage: Write pending changes