Skip to content

feat: add wasm registry config to local deployment#647

Merged
reecepbcups merged 6 commits intomainfrom
reece/local-oci-registry
May 20, 2025
Merged

feat: add wasm registry config to local deployment#647
reecepbcups merged 6 commits intomainfrom
reece/local-oci-registry

Conversation

@reecepbcups
Copy link
Member

@reecepbcups reecepbcups commented May 16, 2025

Summary

ref: Lay3rLabs/wavs-foundry-template#163

This allows a local only registry to be run for rapid iteration with a pre testnet/prod enviroment. This avoids the need to setup wa.dev API keys and just allows it to work for users.

NOTE: this means the template no longer uses the set-source-digest --wasm-digest <> command.

image

image

@reecepbcups reecepbcups changed the title WIP: feat: add local oci registry WIP: feat: add local oci registry config May 16, 2025
@reecepbcups reecepbcups changed the title WIP: feat: add local oci registry config feat: add wasm registry config to local deployment May 19, 2025
@reecepbcups reecepbcups marked this pull request as ready for review May 19, 2025 21:45
@reecepbcups reecepbcups marked this pull request as draft May 19, 2025 21:49
@reecepbcups reecepbcups marked this pull request as ready for review May 19, 2025 22:12
Copy link
Collaborator

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it helps the template, let's get this in a.s.a.p.... but @reecepbcups for a follow-up issue:

  1. where does the localhost port here come from? hardcoding 8090 feels kinda arbitrary
  2. should this stuff as a whole (other than dynamic domain) not come from wavs.toml somehow?

@reecepbcups
Copy link
Member Author

reecepbcups commented May 20, 2025

  • 8090 is the default upstream for the wasi warg registry
  • I thought about this last night as well. For now I don't think it's required. If a user is not using wa.dev or the localhost, idk what they are using that is warg compatible. Once we find a use case to support OCI registries (ghcr), then yes a wavs.toml would make sense. Until that use case comes up we can stick like so

@reecepbcups reecepbcups merged commit 248e294 into main May 20, 2025
2 checks passed
@reecepbcups reecepbcups deleted the reece/local-oci-registry branch May 20, 2025 13:09
@dakom
Copy link
Collaborator

dakom commented May 20, 2025

ok cool, I opened #651 but stuck it on the 0.5.0 low-priority roadmap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants