Conversation
todo: test + wire up
use config vars instead
ueco-jb
left a comment
There was a problem hiding this comment.
Good implementation, found mostly few nitpicks. 👍
taskfile/bootstrap.yml
Outdated
| vars: | ||
| OPERATOR_CID: | ||
| sh: jq -r '.cid' {{.DEPLOYMENTS_ARTIFACTS_PATH}}/operator-cid.json | ||
| TARGET_HANDLE: "ismellike.bsky.social" |
There was a problem hiding this comment.
I think its better to have it as a config var. All nodes will know which target to handle since it's included in service json. Typically env is reserved for secrets instead
There was a problem hiding this comment.
I'm fine with the config, let's just not have it hardcoded in the taskfile. 😀
There was a problem hiding this comment.
Still has to be set somewhere in a taskfile what about we set in config.yml then?
| // Construct the post URI from the event data (repo already includes full DID prefix) | ||
| let post_uri = format!("at://{}/app.bsky.feed.post/{}", repo, rkey); |
There was a problem hiding this comment.
repo here is used straight up from the event, without validation. Simple repo.starts_with("did:") should cover that.
There was a problem hiding this comment.
repo == did no need to validate if we get to this point I think
There was a problem hiding this comment.
This line is called just at the beginning of handle event, where that field is decoded into a string.
https://github.com/Lay3rLabs/wavs-wasi/blob/c02f62264fdd279adc71622f595e2a6cd7da3c92/wit-definitions/types/wit/events.wit#L41
If I'm not missing anything, no validation happens before.
ueco-jb
left a comment
There was a problem hiding this comment.
Let's just not merge that target handle in the bootstrap.yml and we're good to go!
Great work Gabe! Now it's a very solid example of WAVS use and a great demo. 🔥
Working:
TODO:
download-witback to main when AT protocol triggers wavs-wasi#94 is merged