Open
Conversation
Always have to look up what this command is to test locally
helper for local testing
…g-ownership-of-all-contracts 221 Transfer Ownership Script
Supeeerpower
force-pushed
the
224-update-bls-list-operator-script
branch
from
745fd35 to
fc0c88e
Compare
Supeeerpower
force-pushed
the
224-update-bls-list-operator-script
branch
from
fc0c88e to
b2609f7
Compare
Supeeerpower
force-pushed
the
224-update-bls-list-operator-script
branch
from
fe90194 to
e3b8834
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates BLS list operator scripts to replace registryCoordinator with slashingRegistryCoordinator and improves operator listing functionality. The changes address issue #224 by modernizing the operator listing system and removing outdated broadcast operations.
- Replace deprecated RegistryCoordinator with SlashingRegistryCoordinator for BLS middleware
- Remove unnecessary broadcast operations from various shell scripts and Solidity scripts
- Add comprehensive operator listing library with enhanced data structures and JSON output capabilities
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/ecdsa/mirror/list_operators.sh | Remove --broadcast flag from forge script execution |
| scripts/ecdsa/mirror/deploy.sh | Remove --broadcast flag from forge script execution |
| scripts/ecdsa/eigen/list_operators.sh | Remove --broadcast flag and add operator data saving functionality |
| scripts/bls/eigen/list_operators.sh | Remove --broadcast flag and update output file naming convention |
| docker/BLS_CLI.md | Remove docci output constraint from bash code block |
| contracts/script/eigenlayer/ecdsa/WavsMirrorPrepareDeploy.s.sol | Remove vm.startBroadcast/stopBroadcast wrapper |
| contracts/script/eigenlayer/ecdsa/WavsListOperators.s.sol | Remove broadcast wrapper and add JSON output functionality |
| contracts/script/eigenlayer/bls/utils/WavsMiddlewareDeploymentLib.sol | Replace RegistryCoordinator with SlashingRegistryCoordinator implementation |
| contracts/script/eigenlayer/bls/utils/WavsListOperatorsLib.sol | Add comprehensive operator listing library with data structures and utilities |
| contracts/script/eigenlayer/bls/WavsMiddlewareDeployer.s.sol | Update type references from RegistryCoordinator to SlashingRegistryCoordinator |
| contracts/script/eigenlayer/bls/WavsListOperators.s.sol | Refactor to use new WavsListOperatorsLib for operator listing functionality |
| uint256 quorumDenominator; | ||
| } | ||
|
|
||
| Vm internal constant VM = Vm(address(uint160(uint256(keccak256("hevm cheat code"))))); |
There was a problem hiding this comment.
Using a hardcoded address for the VM cheat code is fragile and may break if the cheat code address changes. Consider using vm from the Script contract or importing it properly from forge-std.
Suggested change
| Vm internal constant VM = Vm(address(uint160(uint256(keccak256("hevm cheat code"))))); | |
| // Use the Vm instance from the caller, do not hardcode the address. |
| ISocketRegistry(socketRegistry), | ||
| IAllocationManager(core.allocationManager), | ||
| IPauserRegistry(pauserRegistry), | ||
| "1.0.0" |
There was a problem hiding this comment.
[nitpick] The version string "1.0.0" is hardcoded. Consider making this configurable or using a constant to improve maintainability.
| VM.createDir("deployments/wavs-bls", true); | ||
| } | ||
|
|
||
| string memory json = "{\"totalWeight\":\""; |
There was a problem hiding this comment.
Manual JSON string concatenation is error-prone and hard to maintain. Consider using a JSON library or structured approach for building JSON output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes on #224