Conversation
dakom
approved these changes
Aug 6, 2025
Collaborator
dakom
left a comment
dakom
left a comment
There was a problem hiding this comment.
Left a couple comments, the only one which might be a blocker is the middleware tag, but otherwise LGTM!
taskfile/docker.yml
Outdated
| vars: | ||
| WAVS_DOCKER_IMAGE: "ghcr.io/lay3rlabs/wavs:94f641f" | ||
| MIDDLEWARE_DOCKER_IMAGE: "ghcr.io/lay3rlabs/wavs-middleware:0548d44" | ||
| MIDDLEWARE_DOCKER_IMAGE: "ghcr.io/lay3rlabs/wavs-middleware:local" |
Collaborator
There was a problem hiding this comment.
is this intentional? shouldn't it be latest ?
Collaborator
Author
There was a problem hiding this comment.
intentional for local dev, but I left a note at bottom of PR description to update tag
ueco-jb
reviewed
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #82
2 projects are using TRANSFER_OWNERSHIP:
operator-updater(arbitrarily) andwavs-drand(for coverage on mocks). The other projects were excluded to have coverage forTRANSFER_OWNERSHIP = false.From readme:
Transfer Ownership
After deploying middleware contracts, you may want to transfer ownership of the ECDSA proxy and AVS contracts to different addresses.
Configuration
Set owner addresses in taskfile/config.yml:
Enable ownership transfer in your project's Taskfile:
When
TRANSFER_OWNERSHIPis set totrue, the bootstrap process will automatically transfer ownership after middleware deployment using the addresses configured in config.yml. The system will use the appropriate transfer method based on your deployment mode:middleware:transfer-ownershipmiddleware:mock-transfer-ownershipwith mock-specific environment variablesIf
TRANSFER_OWNERSHIPisfalseor not set, ownership transfer will be skipped entirely.todo:
update tag once Lay3rLabs/wavs-middleware#223 is merged and tagged