This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Conversation
ismellike
approved these changes
Oct 31, 2025
Collaborator
ismellike
left a comment
ismellike
left a comment
There was a problem hiding this comment.
nice lgtm thanks for the explanation
ethanfrey
approved these changes
Oct 31, 2025
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Minor comments
Making it optional and not making this a vec seems small enough
| // currently unused | ||
| ordering: option<u64>, | ||
| // make sure this is unique for every response! | ||
| event-id: response-event-id |
Contributor
There was a problem hiding this comment.
To make this more backwards compatible, you could make this option and None is the same as auto
|
|
||
| // hash any arbitrary payload to generate the event id | ||
| // it's up to you to ensure uniqueness here | ||
| hash(list<u8>), |
Contributor
There was a problem hiding this comment.
Examples would be good.
For TG example, you’d use hash(update_id.as_bytes()) or something like that?
Contributor
|
I would suggest simplifying to:
Hash could be added as well, but why not let the component hash if it wants rather than complicate wit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIT change for Lay3rLabs/WAVS#1063