-
Notifications
You must be signed in to change notification settings - Fork 257
DEVREL-930 Oapp solana migrate lzrt v2 #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nazreen
wants to merge
27
commits into
main
Choose a base branch
from
oapp-solana-migrate-lzrt-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b0061fc
evm debug task
nazreen 414feaa
instructions to view sent srings
nazreen 488df76
introduce changes
nazreen a92702f
fix
nazreen e1d5477
fix lzrt v2
nazreen 2415e10
update
nazreen 9a66e43
update generated
nazreen 3e222bc
generated
nazreen 1b45d61
generated
nazreen 93aa25c
fix generation styling
nazreen c272a98
fix generation styling
nazreen fa64904
include alt
nazreen b07d28b
alt
nazreen 8cd2352
alt
nazreen 748504c
alt
nazreen d4a0fd4
name
nazreen 85308ab
comment
nazreen 8ff1f37
remove payer
nazreen 6d33ecf
payer
nazreen 323a019
delete
nazreen 579f05f
rm system program
nazreen a035a99
fixed
nazreen 283078d
update lockfiles
nazreen 6104aac
Merge branch 'main' into oapp-solana-migrate-lzrt-v2
nazreen 815d0a1
remove unused
nazreen b7b21e7
Merge branch 'main' into oapp-solana-migrate-lzrt-v2
nazreen 8b81ec1
Merge branch 'main' into oapp-solana-migrate-lzrt-v2
nazreen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeScript client missing payer account for lzReceive instruction
High Severity
The Rust
LzReceivestruct was updated to include a newpayer: Signer<'info>account at index 0, shiftingstoreto index 1 andpeerto index 2. However, the auto-generated TypeScript client forlzReceivewas not updated accordingly — it still only hasstoreat index 0 andpeerat index 1, completely missing thepayeraccount. While the Executor useslz_receive_types_v2to get the correct account list (which does includepayerviaAddressLocator::Payer), any direct usage of the TypeScriptlzReceivefunction would fail because the account order doesn't match what the program expects.Additional Locations (1)
examples/oapp-solana/programs/my_oapp/src/instructions/lz_receive.rs#L13-L16