-
Notifications
You must be signed in to change notification settings - Fork 256
DEVREL-1012 fix squads vault detection #1871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
PR SummaryImproves Solana address validation and Squads vault detection with network awareness and clearer rules.
Written by Cursor Bugbot for commit cf14b14. This will update automatically on new commits. Configure here. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
Problem
https://4fnetmviidiqkjzenwxe66vgoa0soerr.lambda-url.us-east-1.on.aws/isSquad/${address}) by Squads only works for mainnet.Changes
Updated
isSquadsV4Vaultto takeeid: EndpointIdas first parameter and returnnullfor Solana testnet (40168), since the Squads API only works on mainnet (30168). Throws for unsupported EIDs.Refactored
assertValidSolanaAdminto use flattened early-return structure for better readabilityAllow for PDAs owned by Squads V3 program (
SMPLecH534NA9acpos4G6x7uf3LWbCAwZQE9e8ZekMu) - allows with warning instead of throwingAddressed missing case of when address is off curve by not owned by System Program or a Squads program (we should throw)
Removed
isPossibleSquadsVaultfunction (unused, logic consolidated intoassertValidSolanaAdmin)Added debug logging throughout address validation helpers using lazy logger factory pattern (fixes issue where logs weren't respecting
--log-levelflag)Testing
deploy and wire as usual, then refer to Proof of Test section
(update the delegate address in the LZ config)
Proof of Test
Tip: when looking through the logs, search for 'Solana addresses'.
When new delegate is regular (onCurve) address (EKXXXF8kzh4Bnq1HBHVwZgA5egJJWLDYqXmJTQtbbd5D)
When new delegate is a Squads v4 vault on devnet (DokBLkqgnws2GsfBcbowX1bYqk4noYEhcDDdTZDV8Yh)
When new delegate is a Squads v4 Multisig (invalid) on devnet (59jdDuB6khhBf9nwwyJfwGXPeEF2mxTMbQusNXGAXjff)