-
Notifications
You must be signed in to change notification settings - Fork 256
DEVREL-997 Solana OFT wiring: warn when provided address is not the admin/delegate #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
PR SummaryImproves Solana OFT wiring UX by warning when the active signer (or provided multisig) lacks admin/delegate authority.
Written by Cursor Bugbot for commit 39de6b2. This will update automatically on new commits. Configure here. |
| warnings.push( | ||
| `Signing authority (${signingAuthority}) is not the delegate (${delegate}). ` + | ||
| `Use the correct keypair or supply the correct value for --multisig-key if the delegate is a Squads Vault.` | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning triggers incorrectly when delegate is undefined
The getOftAdminAndDelegate function can return delegate as undefined, but validateSigningAuthority compares signingAuthority !== delegate without checking if delegate exists. When delegate is undefined, this comparison always evaluates to true (since any string is not equal to undefined), causing a confusing warning message like "is not the delegate (undefined)" even when no delegate has been set for the OFT.
Additional Locations (1)
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
Problem
When the owner/delegate of a Solana OFT is a Squads Vault, but wire is ran without the
--multisig-keyparam, the error is unhelpful:Changes
Added check of the active keypair or provided multisig against the Solana OFT's admin/delegate
The check will also warn if the wrong multisig key is provided (which will derive to the wrong vault PDA).
Testing
Deploy a Solana OFT
Update the delegate and admin to a Squads vault
Then, change anything in LZ config and run the wire command without the
--multisig-keyparam