fix/verify-contract: - fall back to source-based extraction if there's a mismatch in ABI #1878
Conversation
jadijadi
commented
Dec 12, 2025
jadijadi
commented
- Try using deployment ABI first, but fall back to source-based extraction if there's a mismatch
- stable-testnet added to networks.ts
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
There was a problem hiding this comment.
Pull request overview
This PR enhances the contract verification process by implementing a fallback mechanism when there's a constructor ABI mismatch, and adds support for new blockchain networks (stable-testnet and codex).
Key Changes:
- Implements try-catch fallback logic to extract constructor ABI from source code when deployment ABI encoding fails
- Adds stable-testnet and codex network configurations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/verify-contract/src/hardhat-deploy/verify.ts | Adds fallback mechanism to extract constructor ABI from source when deployment ABI fails |
| packages/verify-contract/src/common/networks.ts | Adds stable-testnet (chainId 2201) and codex (chainId 81224) network definitions |
| .changeset/purple-items-argue.md | Documents the minor version change for the verify-contract package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| logger.warn( | ||
| `Skipping contract ${contractName} in ${fileName} on network ${networkName} due to constructor encoding error: ${error}. ` + | ||
| `Tried fallback to source-based extraction but that also failed: ${sourceError}` | ||
| ) |
There was a problem hiding this comment.
The error message concatenates error objects directly into the string, which may produce unhelpful output like '[object Object]'. Consider using error.message or a similar property to display meaningful error information.
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
jadijadi
force-pushed
the
jadi/continue-on-missing-data
branch
from
830fe2c to
0f17755
Compare
PR SummaryBehavioral change
Networks
Refactors/Tests
Release
Written by Cursor Bugbot for commit 6ed471e. This will update automatically on new commits. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| codex: { | ||
| chainId: 81224, | ||
| apiUrl: 'https://explorer.codex.xyz/', | ||
| }, |
There was a problem hiding this comment.
Codex network API URL missing required /api path
The codex network's apiUrl is configured as 'https://explorer.codex.xyz/' but is missing the /api path that all other custom explorer URLs in this file include (e.g., 'https://explorer.ebi.xyz/api', 'https://explorer.gravity.xyz/api'). Since the verification code sends requests directly to this URL, contract verification attempts on the Codex network will fail because requests will be sent to the wrong endpoint.
🚨 E2E Tests FailedThe E2E tests failed during CI. These tests validate real blockchain interactions and may fail due to:
This is non-blocking and does not prevent merging. Check the action logs above for detailed failure information. |
…traction If encoding fails due to argument mismatch, try extracting constructor from source This handles cases where the ABI is incomplete but source code has the full signature
jadijadi
force-pushed
the
jadi/continue-on-missing-data
branch
from
0f17755 to
6ed471e
Compare
🧪 E2E Test StatusE2E tests are non-blocking and validate real blockchain interactions. Failures may occur due to network issues, RPC rate limits, or external service downtime. Test Runs (Newest First):
|
3 participants
