Skip to content

fix: skip ensure docker for L1 deploy outside of devnet #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grezle merged 1 commit into from
Oct 20, 2025
Merged

fix: skip ensure docker for L1 deploy outside of devnet #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions pkg/commands/deploy_actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,6 @@ func DeployL1ContractsAction(cCtx *cli.Context) error {
logger := common.LoggerFromContext(cCtx)
caser := cases.Title(language.English)

// Check if docker is running, else try to start it
err := common.EnsureDockerIsRunning(cCtx)
if err != nil {
return cli.Exit(err.Error(), 1)
}

// Start timing execution runtime
startTime := time.Now()

Expand All @@ -261,6 +255,7 @@ func DeployL1ContractsAction(cCtx *cli.Context) error {
contextName := cCtx.String("context")

// Check for context
var err error
var yamlPath string
var rootNode, contextNode *yaml.Node
if contextName == "" {
Expand Down
7 changes: 7 additions & 0 deletions pkg/commands/devnet_actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,13 @@ func StartDevnetAction(cCtx *cli.Context) error {

// Deploy the contracts after starting devnet unless skipped
if !skipDeployContracts {
// Check if docker is running, else try to start it
err := common.EnsureDockerIsRunning(cCtx)
if err != nil {
return cli.Exit(err.Error(), 1)
}

// Call deploy L1 action within devnet context
if err := DeployL1ContractsAction(cCtx); err != nil {
return fmt.Errorf("deploy-contracts failed - please restart devnet and try again: %w", err)
}
Expand Down
Loading