Skip to content

fix: remove duplicate success logging from REST middleware #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sashaodessa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove duplicate success logging from REST middleware #2448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions api/proxy/servers/rest/middleware/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,17 @@ func withLogging(
"status", scw.status, "duration", time.Since(start),
}

if err != nil {
args = append(args, "error", err.Error())
if scw.status >= 400 && scw.status < 500 {
log.Warn("request completed with 4xx error", args...)
} else {
log.Error("request completed with error", args...)
}
// Success-path logging is handled by the handlers (e.g. "Processed request").
// Keeping middleware logging only for error paths avoids duplicate log lines.
if err == nil {
return
}

args = append(args, "error", err.Error())
if scw.status >= 400 && scw.status < 500 {
log.Warn("request completed with 4xx error", args...)
} else {
// This log line largely duplicates the logging in the handlers.
// Only difference being that we have duration here, whereas the handlers log the cert.
// TODO: should we also pass the cert via the requestContext to rid of the log lines in the handlers?
log.Info("request completed", args...)
log.Error("request completed with error", args...)
}
}
}