chore: fix relay client burst limit#2461
Open
cosmoknightt wants to merge 1 commit intoLayr-Labs:masterfrom
Open
chore: fix relay client burst limit#2461cosmoknightt wants to merge 1 commit intoLayr-Labs:masterfrom
cosmoknightt wants to merge 1 commit intoLayr-Labs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
- Coverage 39.46% 39.44% -0.02%
==========================================
Files 550 550
Lines 51083 51083
==========================================
- Hits 20160 20150 -10
- Misses 28382 28387 +5
- Partials 2541 2546 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs claimed the client burst limit defaults to 2MiB, but the actual flag value has been 400MiB since day one. That's a 200x difference which is pretty misleading if you're trying to figure out how much burst capacity clients actually get.
Also fixed the bandwidth per second doc (was 2MiB/s, actually 40MiB/s).